AddTimeUnitArgument recipe

[joanvr]

What's changed?

Added a new recipe AddTimeUnitArgument to solve the timeout and timevalue migrations. This way is more maintainable since it only requires changes in the declarative yml recipe instead of changing the recipe themselves.

Checklist

• I've added unit tests to cover both positive and negative cases
• I've added the license header to any new files through ./gradlew licenseFormat
• I've used the IntelliJ auto-formatter on affected files
• I've updated the documentation (if applicable)

[timtebeek]

I'm wondering what happens to the method type when we don't replace the method, but only add an argument; wouldn't the method type post-recipe still refer to the original (usually single argument) method instead of the new multiple argument method? I'd always thought that replaceArguments was only when you replace with the same number and type or arguments; not when you switch to a different method.

If the method type is updated correctly there's no need for a change, otherwise it might be best to replace the whole method rather than just the arguments.

[joanvr]

yes, the method type is updated correctly

[timtebeek]

Already approved, but do look at my last question regarding replace arguments versus replace method and the resulting method type.