Add refaster recipes to simplify expected value

[timo-abele]

What's changed?

3 simple refaster recipes added

What's your motivation?

salvaging the changes in #472
adding missing transformations I noticed.

Anything in particular you'd like reviewers to focus on?

These recipes are simpler that the ones in #472: they don't need generics and should work in Java 8. But each test yields:

Recipe was expected to make a change but made no changes.

Anyone you would like to review specifically?

@timtebeek

Have you considered any alternatives or workarounds?

SimplifyChainedAssertJAssertion could probably be extended to cover these cases, but I think refaster is the appropriate level of complexity

Any additional context

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[knutwannheden]

I think you want to use primitive types in the method signatures.

[timo-abele]

I tried it for both "Integer" recipes, but still get "Recipe was expected to make a change but made no changes." for all three tests.

[timtebeek]

Had another quick look after applying some small changes, but the before matcher in the generated recipes is failing to match on the hihglighted line.

Any insights there @knutwannheden ? Seems like a good use case to do this type of simplification with Refaster recipes.

[timtebeek]

Hi @timo-abele ; I've started two new efforts to (better) leverage the work done by our friends at Picnic:

• Add Picnic AssertJ rules to AssertJ best practices #527
• Troubleshoot mismatched AssertJ AbstractStringAssert.isEqualTo("") rewrite-templating#91
• JavaTemplateSemanticallyEqual fails to match AssertJ's assertThat("foo").isEqualTo("") rewrite#4423

I believe that could replace the recipes you've added here, given that theirs are already similar:

• https://error-prone.picnic.tech/refasterrules/AssertJIntegerRules/#abstractintegerassertiszero
• https://error-prone.picnic.tech/refasterrules/AssertJObjectRules/#assertthatisisequalto

Would you agree with closing this effort and instead replying on the upstream EPS project for these improvements?

[timtebeek]

Closing this effort for now, as we need an upstream fix in rewrite-templating first, and in parallel we also have this PR that might cover some of the same

• Chained AssertJ assertions should be simplified to the corresponding dedicated assertion #556

Note that the work here is much appreciated though! It's just the generics that are tripping us up to merge this as-is without additional effort put into openrewrite/rewrite-templating#91 first.

Hope to revisit as soon as support is there though, and linking this issue into that one to be notified.

[timtebeek]

Upstream we've seen a fix introduced

• Fixes for type attribution and TypeUtils#isAssignableTo() rewrite#4427

That means we now should see results from the existing ErrorProne Support recipes we pull in

rewrite-testing-frameworks/src/main/resources/META-INF/rewrite/assertj.yml

Lines 31 to 45 in 3412efb

	- tech.picnic.errorprone.refasterrules.AssertJBigDecimalRulesRecipes
	- tech.picnic.errorprone.refasterrules.AssertJBigIntegerRulesRecipes
	- tech.picnic.errorprone.refasterrules.AssertJBooleanRulesRecipes
	- tech.picnic.errorprone.refasterrules.AssertJByteRulesRecipes
	- tech.picnic.errorprone.refasterrules.AssertJCharSequenceRulesRecipes
	- tech.picnic.errorprone.refasterrules.AssertJDoubleRulesRecipes
	- tech.picnic.errorprone.refasterrules.AssertJFloatRulesRecipes
	- tech.picnic.errorprone.refasterrules.AssertJIntegerRulesRecipes
	- tech.picnic.errorprone.refasterrules.AssertJLongRulesRecipes
	- tech.picnic.errorprone.refasterrules.AssertJNumberRulesRecipes
	- tech.picnic.errorprone.refasterrules.AssertJPrimitiveRulesRecipes
	- tech.picnic.errorprone.refasterrules.AssertJRulesRecipes
	- tech.picnic.errorprone.refasterrules.AssertJShortRulesRecipes
	- tech.picnic.errorprone.refasterrules.AssertJStringRulesRecipes
	- tech.picnic.errorprone.refasterrules.AssertJThrowingCallableRulesRecipes

That reduces the need to reimplement them here. Thanks again for uncovering that we had an issue which is now solved!