Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Data Faker migration recipe coming from Java Faker #494

Closed
wants to merge 2 commits into from

Conversation

timtebeek
Copy link
Contributor

Fixes #490

@timtebeek timtebeek self-assigned this Mar 12, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/main/java/org/openrewrite/java/testing/junit5/AssertTrueInstanceofToAssertInstanceOf.java
    • lines 39-38
    • lines 59-59
    • lines 77-77
  • src/main/java/org/openrewrite/java/testing/junit5/RemoveDuplicateTestTemplates.java
    • lines 32-31
  • src/test/java/org/openrewrite/java/testing/junit5/RemoveTryCatchFailBlocksTest.java
    • lines 30-29

@timtebeek timtebeek marked this pull request as ready for review March 12, 2024 23:52
@timtebeek timtebeek closed this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Migrate from Java Faker to Datafaker
1 participant