Hamcrest Is matcher from core

[timo-abele]

this testcase uses a different import for the is matcher

What's changed?

added a testcase where the is matcher is imported via import static org.hamcrest.core.Is.is;

What's your motivation?

Fix #497

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[github-actions]

Some suggestions could not be made:

• src/test/java/org/openrewrite/java/testing/datafaker/JavaFakerToDataFakerTest.java
  • lines 19-18
  • lines 33-32

[timtebeek]

Thanks for the helpful test to reproduce & pointing out the likely cause. We can either change the Java recipe, or run a declarative recipe before this change to get this to work, as indicated here.

An addition of this recipe

  - org.openrewrite.java.ChangeMethodTargetToStatic:
      methodPattern: org.hamcrest.core.Is is(..)
      fullyQualifiedTargetTypeName: org.hamcrest.Matchers

As the very first recipe here would allow both RemoveIsMatcher and HamcrestIsMatcherToAssertJ to work cases that currently use org.hamcrest.core.Is.

rewrite-testing-frameworks/src/main/resources/META-INF/rewrite/hamcrest.yml

Lines 41 to 46 in bcb4449

	recipeList:
	# First remove wrapping `is(Matcher)` calls such that further recipes will match
	- org.openrewrite.java.testing.hamcrest.RemoveIsMatcher
	# Then remove calls to `MatcherAssert.assertThat(String, is(Matcher))`
	- org.openrewrite.java.testing.hamcrest.HamcrestIsMatcherToAssertJ

Might be worth exploring if there's similar cases that could benefit from such a standardization-ahead-of-migration as well, but optional for this PR.

Thanks for helping figure this one out!

[timtebeek]

Thanks for getting this started @timo-abele! I've moved the test and applied the above suggestion such that it now passes. Good to have this covered!