Hamcrest Is matcher from core
#498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this testcase uses a different import for the is matcher
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Thanks for the helpful test to reproduce & pointing out the likely cause. We can either change the Java recipe, or run a declarative recipe before this change to get this to work, as indicated here. An addition of this recipe - org.openrewrite.java.ChangeMethodTargetToStatic:
methodPattern: org.hamcrest.core.Is is(..)
fullyQualifiedTargetTypeName: org.hamcrest.MatchersAs the very first recipe here would allow both Might be worth exploring if there's similar cases that could benefit from such a standardization-ahead-of-migration as well, but optional for this PR. Thanks for helping figure this one out! |
timtebeek
approved these changes
Apr 14, 2024
|
Thanks for getting this started @timo-abele! I've moved the test and applied the above suggestion such that it now passes. Good to have this covered! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this testcase uses a different import for the is matcher
What's changed?
added a testcase where the is matcher is imported via
import static org.hamcrest.core.Is.is;What's your motivation?
Fix #497
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Any additional context
Checklist