Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added to notMatchers #514

Merged
merged 1 commit into from
May 16, 2024
Merged

Added to notMatchers #514

merged 1 commit into from
May 16, 2024

Conversation

kevin-scholten
Copy link
Contributor

What's changed?

I've added 2 'notMatcher's to HamcrestNotMatcherToAssertJ.

What's your motivation?

I've added two notMatcher's that were not automatically changed in my project. By adding these two it fixed my problem.

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@timtebeek timtebeek self-requested a review May 16, 2024 13:20
@timtebeek timtebeek added enhancement New feature or request recipe Recipe request labels May 16, 2024
@timtebeek
Copy link
Contributor

Awesome; thanks a lot for the immediate fix! Good to see you worked out what to add where, and able to confirm that it actually worked.

On a wider note: did you already notice Apache Wicket has some OpenRewrite migration recipes as well? I added those a while back, and think those might be interesting for Topicus as well, especially as that also runs some lambda migration recipes. Hope that helps!

If you find any more issues or have other ideas let me know! Glad to see the project put to use there. :)

@timtebeek timtebeek merged commit baee2bf into openrewrite:main May 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request recipe Recipe request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants