Do not reduce visibility of extended classes in TestsShouldNotBePublic
#524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtebeek
changed the title
TestsShouldNotBePublic
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/main/java/org/openrewrite/java/testing/cleanup/TestsShouldNotBePublic.java
Outdated
Show resolved
Hide resolved
…NotBePublic.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Turn
TestsShouldNotBePublicinto aScanningRecipethat finds any extended classes, and excludes those from the recipe run.What's your motivation?
Fixes #309
TestsShouldNotBePublicshould not reduce visibility if test classes are extended #309Anything in particular you'd like reviewers to focus on?
The approach of accumulating all extended classes is rather crude, but works. Didn't immediately see a good way to limit this further, as there's no guarantees as to features of classes that extend a common test base class, nor features that such a base class would have.