Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jmockit Expectations with no times or result should be transformed to Mockito verify statement #530

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Jmockit Expectations with no times or result should be transformed to Mockito verify statement #530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5042d5f
Ensure Jmockit expectations with no times or result transform to a mo…
shivanisky Jun 19, 2024
dd1b2c4
Minor polish to text blocks
timtebeek Jun 19, 2024
ebdbf23
Make times, minTimes, maxTimes more flexible as it was originally so …
shivanisky Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 30 additions & 13 deletions src/main/java/org/openrewrite/java/testing/jmockit/ExpectationsBlockRewriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

import org.openrewrite.Cursor;
import org.openrewrite.ExecutionContext;
import org.openrewrite.internal.lang.Nullable;
import org.openrewrite.java.JavaParser;
import org.openrewrite.java.JavaTemplate;
import org.openrewrite.java.JavaVisitor;
Expand Down Expand Up @@ -118,22 +119,31 @@ private void rewriteMethodBody(List<Statement> expectationStatements) {
return;
}
J.MethodInvocation invocation = (J.MethodInvocation) expectationStatements.get(0);
if (!mockInvocationResults.getResults().isEmpty()) {
boolean hasExpectationsResults = !mockInvocationResults.getResults().isEmpty();
if (hasExpectationsResults) {
// rewrite the statement to mockito if there are results
rewriteExpectationResult(mockInvocationResults.getResults(), invocation);
} else if (nextStatementCoordinates.isReplacement()) {
// if there are no results and the Expectations block is not yet replaced, remove it
removeExpectationsStatement();
}

boolean hasTimes = false;
if (mockInvocationResults.getTimes() != null) {
hasTimes = true;
writeMethodVerification(invocation, mockInvocationResults.getTimes(), "times");
}
if (mockInvocationResults.getMinTimes() != null) {
hasTimes = true;
writeMethodVerification(invocation, mockInvocationResults.getMinTimes(), "atLeast");
}
if (mockInvocationResults.getMaxTimes() != null) {
hasTimes = true;
writeMethodVerification(invocation, mockInvocationResults.getMaxTimes(), "atMost");
}
if (!hasExpectationsResults && !hasTimes) {
writeMethodVerification(invocation, null, null);
}
}

private void rewriteExpectationResult(List<Expression> results, J.MethodInvocation invocation) {
Expand Down Expand Up @@ -182,18 +192,22 @@ private void removeExpectationsStatement() {
methodBody.getStatements().get(bodyStatementIndex + numStatementsAdded).getCoordinates().after();
}

private void writeMethodVerification(J.MethodInvocation invocation, Expression times, String verificationMode) {
private void writeMethodVerification(J.MethodInvocation invocation, @Nullable Expression times, @Nullable String verificationMode) {
String fqn = getInvocationSelectFullyQualifiedClassName(invocation);
if (fqn == null) {
// cannot write a verification statement for an invocation without a select field
return;
}
visitor.maybeAddImport("org.mockito.Mockito", "verify");
visitor.maybeAddImport("org.mockito.Mockito", verificationMode);
if (verificationMode != null) {
visitor.maybeAddImport("org.mockito.Mockito", verificationMode);
}

List<Object> templateParams = new ArrayList<>();
templateParams.add(invocation.getSelect());
templateParams.add(times);
if (times != null) {
templateParams.add(times);
}
templateParams.add(invocation.getName().getSimpleName());

String verifyTemplate = getVerifyTemplate(invocation.getArguments(), fqn, verificationMode, templateParams);
Expand Down Expand Up @@ -251,17 +265,20 @@ private static void appendToTemplate(StringBuilder templateBuilder, boolean buil
templateBuilder.append(templateField);
}

private static String getVerifyTemplate(List<Expression> arguments, String fqn, String verificationMode, List<Object> templateParams) {
private static String getVerifyTemplate(List<Expression> arguments, String fqn, @Nullable String verificationMode, List<Object> templateParams) {
StringBuilder templateBuilder = new StringBuilder("verify(#{any(" + fqn + ")}"); // verify(object
if (verificationMode != null) {
templateBuilder.append(", ").append(verificationMode).append("(#{any(int)})"); // verify(object, times(2)
}
templateBuilder.append(").#{}("); // verify(object, times(2)).method(

if (arguments.isEmpty()) {
return "verify(#{any(" + fqn + ")}, "
+ verificationMode
+ "(#{any(int)})).#{}();";
templateBuilder.append(");"); // verify(object, times(2)).method();
return templateBuilder.toString();
}
StringBuilder templateBuilder = new StringBuilder("verify(#{any(" + fqn + ")}, "
+ verificationMode
+ "(#{any(int)})).#{}(");

boolean hasArgument = false;
for (Expression argument : arguments) {
for (Expression argument : arguments) { // verify(object, times(2).method(anyLong(), any Int()
if (argument instanceof J.Empty) {
continue;
} else if (argument instanceof J.Literal) {
Expand All @@ -276,7 +293,7 @@ private static String getVerifyTemplate(List<Expression> arguments, String fqn,
if (hasArgument) {
templateBuilder.delete(templateBuilder.length() - 2, templateBuilder.length());
}
templateBuilder.append(");");
templateBuilder.append(");"); // verify(object, times(2).method(anyLong(), any Int());
return templateBuilder.toString();
}

Expand Down
Loading