Migrate JMockit Verifications to Mockito

[shivanisky]

Tests are failing, need to fix and also add tests once they pass. The import for verify is not being added. I don't know why this is not working as it is working for the when statements and the same code is being used.

https://jmockit.github.io/tutorial/Mocking.html#verification
https://www.javadoc.io/doc/org.jmockit/jmockit/1.45/mockit/Verifications.html

What's changed?

What's your motivation?

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[timtebeek]

@tinder-dthomson Any thoughts on this PR from your experience with the frameworks & recipes?

[tinder-dthomson]

@tinder-dthomson Any thoughts on this PR from your experience with the frameworks & recipes?

I would not recommend removing the type validation, frustrating as it is. Usually this happens when you're trying to reference types that are not properly loaded, which shouldn't be a major problem in a unit test (just use standard java classes).

[timtebeek]

The type validation is only disabled selectively for method invocations on this one test that indeed uses a custom object.

rewrite-testing-frameworks/src/test/java/org/openrewrite/java/testing/jmockit/JMockitVerificationsToMockitoTest.java

Lines 197 to 200 in be42e84

	void whenClassArgumentMatcher() {
	//language=java
	rewriteRun(
	spec -> spec.afterTypeValidationOptions(TypeValidation.builder().methodInvocations(false).build()),

We could modify this test to indeed use some class from the JDK itself to get around that, even if we would similarly lack type information in actual cases as well. That makes me inclined to keep this as it is, seeing how it's use is limited to a case we indeed can't seem to cover as easily. We've discussed this in some more detail on Discord; there's one option left to restore .imports(fqn) and add .contextSensitive(), but overall I'd say this is great work already, and need not be help up over this small imperfection that's common with other mocking frameworks as well.

[timtebeek]

Approved already from my side; let me know if either of you feels we should further explore the missing types for verify before we merged.

I'd say the missing types are acceptable here given the limited scope of these migration recipes, and hard to work around (in a performant manner) for limited added value, as there's no method or recipe chaining expected here.

[tinder-dthomson]

Great contribution!