assertInstanceOf not converted from JUnit5 to assertJ
#606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timo-abele
force-pushed
the
demo/assertj-instanceof-miss
branch
from
3952f19
to
9b6de84
Compare
timtebeek
changed the title
assertInstanceOf not converted from JUnit5 to assertJ
|
Thanks for the suggestion! This likely needs a dedicated recipe, similar to the other examples seen here: rewrite-testing-frameworks/src/main/resources/META-INF/rewrite/assertj.yml Lines 459 to 468 in 8fb11c8 Anyone welcome to fill in the missing piece here to make it a reality. |
timtebeek
requested review from
timtebeek
and removed request for
jevanlingen
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/test/java/org/openrewrite/java/testing/assertj/JUnitAssertInstanceOfToAssertThatTest.java
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/testing/assertj/JUnitAssertInstanceOfToAssertThatTest.java
Show resolved
Hide resolved
timtebeek
reviewed
Nov 4, 2024
src/test/java/org/openrewrite/java/testing/assertj/AssertJBestPracticesTest.java
Outdated
Show resolved
Hide resolved
timtebeek
reviewed
Nov 4, 2024
src/test/java/org/openrewrite/java/testing/assertj/AssertJBestPracticesTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
timtebeek
reviewed
Nov 4, 2024
src/main/java/org/openrewrite/java/testing/assertj/JUnitAssertInstanceOfToAssertThat.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/testing/assertj/JUnitAssertInstanceOfToAssertThatTest.java
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/testing/assertj/JUnitAssertInstanceOfToAssertThatTest.java
Show resolved
Hide resolved
timtebeek
reviewed
Nov 4, 2024
src/main/java/org/openrewrite/java/testing/assertj/JUnitAssertInstanceOfToAssertThat.java
Outdated
Show resolved
Hide resolved
timtebeek
reviewed
Nov 4, 2024
src/main/java/org/openrewrite/java/testing/assertj/JUnitAssertInstanceOfToAssertThat.java
Outdated
Show resolved
Hide resolved
timtebeek
reviewed
Nov 4, 2024
src/main/java/org/openrewrite/java/testing/assertj/JUnitAssertInstanceOfToAssertThat.java
Outdated
Show resolved
Hide resolved
timtebeek
reviewed
Nov 4, 2024
src/main/java/org/openrewrite/java/testing/assertj/JUnitAssertInstanceOfToAssertThat.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/testing/assertj/JUnitAssertInstanceOfToAssertThatTest.java
Show resolved
Hide resolved
Co-authored-by: Tim te Beek <timtebeek@gmail.com>
timtebeek
reviewed
Nov 4, 2024
src/main/java/org/openrewrite/java/testing/assertj/JUnitAssertInstanceOfToAssertThat.java
Outdated
Show resolved
Hide resolved
timtebeek
reviewed
Nov 4, 2024
src/main/java/org/openrewrite/java/testing/assertj/JUnitAssertInstanceOfToAssertThat.java
Outdated
Show resolved
Hide resolved
timtebeek
reviewed
Nov 4, 2024
src/main/java/org/openrewrite/java/testing/assertj/JUnitAssertInstanceOfToAssertThat.java
Outdated
Show resolved
Hide resolved
…itly needed in a different order
src/main/java/org/openrewrite/java/testing/assertj/JUnitAssertInstanceOfToAssertThat.java
Outdated
Show resolved
Hide resolved
…InstanceOfToAssertThat.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
timtebeek
approved these changes
Nov 5, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
What's your motivation?
Reproducing an observed conversion miss.
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Any additional context
I'm not sure with sub recipe should convert this so I am using the best practices recipe as a catch-all.
Checklist