Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also exclude omitted dependencies #4463

Closed
wants to merge 1 commit into from

Conversation

timtebeek
Copy link
Contributor

What's changed?

What's your motivation?

When conflicts occur dependencies are omitted; when we then exclude from the conflict, the omitted dependency can resurface. The goal of ExcludeDependency is to fully exclude a dependency, not to see the omitted conflict being used. We should then also add <exclusion> where dependencies are omitted.

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@timtebeek
Copy link
Contributor Author

As discussed on
our OSS Slack:

I've not had time to dive in again; what I think is happening here is that we do not mark the log4j-api as a transitive dependency if that's omitted for conflict ; that's technically correct, but when we then exclude the conflicted dependencies elsewhere it will no longer be omitted
for a structural fix we'd ought to exclude the transitive dependency even when omitted due to a conflict, I think

@timtebeek timtebeek added bug Something isn't working test provided Already replicated with a unit test, using JUnit pioneer's ExpectedToFail labels Sep 30, 2024
@ckcd ckcd mentioned this pull request Oct 9, 2024
3 tasks
@timtebeek
Copy link
Contributor Author

@timtebeek timtebeek closed this Oct 27, 2024
@timtebeek timtebeek deleted the also-exclude-omitted-dependencies branch October 27, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test provided Already replicated with a unit test, using JUnit pioneer's ExpectedToFail
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant