-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not override version property placeholder in UpgradeDependencyVersion #4579
Draft
dimijdriven
wants to merge
10
commits into
openrewrite:main
Choose a base branch
from
dimijdriven:bug-474-placeholder-overwrite
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Do not override version property placeholder in UpgradeDependencyVersion #4579
dimijdriven
wants to merge
10
commits into
openrewrite:main
from
dimijdriven:bug-474-placeholder-overwrite
Commits on Oct 14, 2024
-
bug-474: added relevant test, in some cases the provided requested va…
…lue contains the version, I added an extra check getting the value directly from the pom
Configuration menu - View commit details
-
Copy full SHA for ffef977 - Browse repository at this point
Copy the full SHA ffef977View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5468e68 - Browse repository at this point
Copy the full SHA 5468e68View commit details -
Configuration menu - View commit details
-
Copy full SHA for d3f3382 - Browse repository at this point
Copy the full SHA d3f3382View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1db63db - Browse repository at this point
Copy the full SHA 1db63dbView commit details -
Update rewrite-maven/src/main/java/org/openrewrite/maven/UpgradeDepen…
…dencyVersion.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for b65710b - Browse repository at this point
Copy the full SHA b65710bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fb77bf - Browse repository at this point
Copy the full SHA 0fb77bfView commit details
Commits on Oct 15, 2024
-
Update rewrite-maven/src/main/java/org/openrewrite/maven/UpgradeDepen…
…dencyVersion.java Co-authored-by: Tim te Beek <timtebeek@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 27c7f2c - Browse repository at this point
Copy the full SHA 27c7f2cView commit details
Commits on Oct 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8937a6d - Browse repository at this point
Copy the full SHA 8937a6dView commit details
Commits on Oct 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c030b53 - Browse repository at this point
Copy the full SHA c030b53View commit details -
Configuration menu - View commit details
-
Copy full SHA for 822bc95 - Browse repository at this point
Copy the full SHA 822bc95View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.