Update jupyter:latest to python:v2
#1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
StevenMaude
commented
Jul 17, 2024
| @@ -74,7 +74,7 @@ This removes any code blocks in the notebook from the rendered html; to keep the | |||
| To run this within an OpenSAFELY action, you can use the following run command: | |||
|
|
|||
| ``` | |||
| run: jupyter:latest jupyter nbconvert /workspace/analysis/notebook.ipynb --execute --to html --output-dir=/workspace/output --no-input --ExecutePreprocessor.timeout=86400 | |||
| run: python:v2 jupyter nbconvert /workspace/analysis/notebook.ipynb --execute --to html --output-dir=/workspace/output --no-input --ExecutePreprocessor.timeout=86400 | |||
| ``` | |||
|
|
|||
| Refer to an [example of this, implemented as an OpenSAFELY action](https://github.com/opensafely/mechanical-valve-anticoag/blob/1f158504ba5a74470b11c8d73311fb2859d67cb7/project.yaml#L53-L63). | |||
There was a problem hiding this comment.
thought: Arguably, we should change this link to another example too, because it uses jupyter:latest.
There aren't any examples that use python:v2.
There is at least one that uses python:latest, although the actual example is simpler (notebook creates a single HTML output) compared with the example linked here (notebook creates multiple kinds of outputs).
We could address this here, but I also opened #1573 to record this case and others in the documentation.
Deploying opensafely-docs with
|
| Latest commit: |
900dd18
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://73ac80e8.opensafely-docs.pages.dev |
| Branch Preview URL: | https://steve-update-jupyter-image-t.opensafely-docs.pages.dev |
StevenMaude
force-pushed
the
steve/update-jupyter-image-to-python
branch
from
6462762 to
c2bb787
Compare
Including mentioning `python:v2`.
StevenMaude
force-pushed
the
steve/update-jupyter-image-to-python
branch
from
c2bb787 to
900dd18
Compare
iaindillingham
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1571.