Document date arithmetic errors with ceiling dates #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://opensafely-documentation-pr-646.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c8nhh150mal05fdfhdag. |
rebkwok
force-pushed
the
date-arithmetic
branch
from
7294202 to
7bfb18e
Compare
iaindillingham
approved these changes
Mar 14, 2022
Co-authored-by: Iain Dillingham <iaindillingham@users.noreply.github.com>
Nitpicks are in the bit of docs that I just moved and didn't re-read 🙂 but happy to include |
|
Gotcha, sorry, I should have noticed that. Thank you 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document potential errors that can occur when using date arithmetic without filtering out ceiling dates (i.e. null values represented as 9999-12-31. See also opensafely-core/cohort-extractor#751
Also moved the date arithmentic docs to their own section as the current layout may imply they apply specifically to index dates