Fix aggregate
#112
Merged
Fix aggregate
#112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug occurs when the resampling function produces a series of floats, as is the case when it is the mean. Values that are greater than 7.0, but less than 7.5, will be rounded down to 5.
This complements `test_aggregate_mean_by_week` and replaces the low-value `test_resample`.
Previously, we set the table names in `make_event_counts` but referred to them in test functions. Although more verbose, it's easier to reason about if we pass the table names to `make_event_counts`. This way, the table names are set and referred to in the test functions.
We also remove a low-value test.
When the resampling function produced a series of floats, as was the case when it was the mean, values greater than 7.0 but less than 7.5 would be rounded down to 5. Now, values are rounded to the nearest integer and the series is cast to an `int`, so values in this range will be either redacted (e.g. 7.1 -> 7 -> 0) or rounded up to 10 (e.g. 7.5 -> 8 -> 10). Closes #93
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the resampling function produced a series of floats, as was the case when it was the mean, values greater than 7.0 but less than 7.5 would be rounded down to 5. Now, values are rounded to the nearest integer and the series is cast to an
int, so values in this range will be either redacted (e.g. 7.1 -> 7 -> 0) or rounded up to 10 (e.g. 7.5 -> 8 -> 10).Thanks for spotting the bug in ebmdatalab/opensafely-output-review#719, @LFISHER7 and @Jongmassey. I've a couple more issues with this report to address, but will run and request a release when I'm done.
Closes #93