Skip to content

feat: remove Communication from the substation editor and use oscd-publisher plugin #1650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 7, 2025
Merged

feat: remove Communication from the substation editor and use oscd-publisher plugin #1650

merged 10 commits into from
May 7, 2025

Conversation

@noraeb
Copy link
Collaborator

@noraeb noraeb commented Mar 26, 2025 •
edited
Loading

  • Removes the old publisher plug-in from OpenSCD
  • Adds the new publisher plugin
  • Removes communicagtion buttons

Closes #1644

@noraeb noraeb linked an issue Mar 26, 2025 that may be closed by this pull request
Remove Communication from the substation editor & remove publisher plugin #1644
Closed
3 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Mar 26, 2025 •
edited
Loading

PR Preview Action v1.6.1
Preview removed because the pull request was closed.
2025-05-07 09:23 UTC

@noraeb noraeb requested a review from clepski March 31, 2025 07:32
clepski
clepski reviewed Mar 31, 2025
View reviewed changes
@noraeb noraeb force-pushed the feat/use-openenergytools-publisher-plugin branch from 430e4e3 to adf7089 Compare April 10, 2025 12:44
@Sander3003 Sander3003 mentioned this pull request Apr 17, 2025
Open
@clepski
Copy link
Collaborator

clepski commented May 5, 2025

FYI, the publisher has been deployed as a openscd repository and we can replace the openenergytools version, see com-pas#374

@noraeb noraeb force-pushed the feat/use-openenergytools-publisher-plugin branch from adf7089 to a8513cb Compare May 6, 2025 07:01
@noraeb noraeb force-pushed the feat/use-openenergytools-publisher-plugin branch from a8513cb to 1f08594 Compare May 6, 2025 11:17
@noraeb noraeb marked this pull request as draft May 6, 2025 11:55
@noraeb noraeb marked this pull request as ready for review May 6, 2025 14:25
@noraeb noraeb changed the title feat: use open energy tools publisher plugin feat: use oscd-publisher plugin May 6, 2025
@noraeb noraeb force-pushed the feat/use-openenergytools-publisher-plugin branch from 9342cd2 to e7cbc2f Compare May 7, 2025 06:44
@noraeb noraeb changed the title feat: use oscd-publisher plugin feat: remove Communication from the substation editor and use oscd-publisher plugin May 7, 2025
@clepski
Copy link
Collaborator

clepski commented May 7, 2025

Removes the old publisher plug-in from OpenSCD

We can remove the "old" publisher code right? https://github.com/openscd/open-scd/tree/main/packages/plugins/src/editors/publisher

@noraeb noraeb merged commit c850088 into main May 7, 2025
3 checks passed
@noraeb noraeb deleted the feat/use-openenergytools-publisher-plugin branch May 7, 2025 09:23
@github-actions github-actions bot mentioned this pull request May 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clepski clepski clepski approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove Communication from the substation editor & remove publisher plugin

3 participants

@noraeb @clepski