Tests #38
Merged
Tests #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sepandhaghighi
commented
Feb 7, 2025
sepandhaghighi
commented
- Tests updated
- Minor bugs fixed
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
sadrasabouri
requested changes
Feb 8, 2025
memor/template.py
Outdated
| @@ -42,7 +42,7 @@ def __init__( | |||
| :return: None | |||
| """ | |||
| self._content = None | |||
| self._title = None | |||
| self._title = "unknown" | |||
There was a problem hiding this comment.
I like None better. It's more compatible with integration. Imagine someone wanted to save them in a data frame with a column named title then having some rows as None are easier to detect by NaN detectors and converting them into something better than having them as unknown.
For saving I'm also fine with that field being null when jsonified.
sadrasabouri
approved these changes
Feb 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.