Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

args tuple assignment issue #15

Merged
merged 11 commits into from
Jun 18, 2023
Merged

args tuple assignment issue #15

merged 11 commits into from
Jun 18, 2023

Conversation

sadrasabouri
Copy link
Member

What does this implement/fix? Explain your changes.

There was a bad bug in quote which makes the whole package useless. Since args are tuple we can not modify them in Python. This PR solves that issue.

Any other comments?

  • We should put more efforts on reviews at these first steps.
  • I will add some minor tests check whole package's performance.

@sadrasabouri sadrasabouri changed the title Args tuple issue args tuple issue and overall test Jun 17, 2023
@sadrasabouri sadrasabouri changed the title args tuple issue and overall test args tuple assignment issue Jun 17, 2023
CHANGELOG.md Outdated
@@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
## [Unreleased]
### Added
- Logo
### Changed
- `quote` decorator updated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quote decorator bug fixed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in b6a4cb8.

@sepandhaghighi sepandhaghighi added this to the nava v0.2 milestone Jun 17, 2023
@sepandhaghighi sepandhaghighi added the bug Something isn't working label Jun 17, 2023
@sadrasabouri sadrasabouri self-assigned this Jun 17, 2023
Copy link
Member

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@sadrasabouri sadrasabouri merged commit eb0f15c into dev Jun 18, 2023
36 checks passed
@sadrasabouri sadrasabouri deleted the args-tuple-issue branch June 18, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants