Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test #23

Merged
merged 23 commits into from
Jul 6, 2023
Merged

Test #23

merged 23 commits into from
Jul 6, 2023

Conversation

sepandhaghighi
Copy link
Member

@sepandhaghighi sepandhaghighi commented Jun 27, 2023 •
edited
Loading

Reference Issues/PRs

#18

What does this implement/fix? Explain your changes.

  • Test system modified

Any other comments?

@codecov
Copy link

codecov bot commented Jun 27, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (dev@8369b98). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             dev       #23   +/-   ##
=======================================
  Coverage       ?   100.00%           
=======================================
  Files          ?         3           
  Lines          ?        56           
  Branches       ?         4           
=======================================
  Hits           ?        56           
  Misses         ?         0           
  Partials       ?         0

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sepandhaghighi sepandhaghighi self-assigned this Jun 28, 2023
@sepandhaghighi sepandhaghighi added this to the nava v0.2 milestone Jun 28, 2023
@sepandhaghighi sepandhaghighi marked this pull request as ready for review June 29, 2023 02:48
@sadrasabouri
Copy link
Member

One of the tests is failing (Ubuntu). It suggests using apt-get update. Would you please solve it?

sadrasabouri
sadrasabouri reviewed Jun 29, 2023
View reviewed changes
test/function_test.py
"""
>>> import os
>>> from nava import play
>>> play(os.path.join("others", "test.wav"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find the exact place in which we test the correct performance of the play function. (As you said, comparing waveforms and etc.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github Action does not install any drivers by default. After installing the driver, if the system succeeds in playing the file, no error will occur. That's enough at the moment.

sadrasabouri
sadrasabouri approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Also I trimmed the test.wav down to 60.3KB using sox. Hope everything is right, @sepandhaghighi please check the sound for double-check.

This is the current sound's spectrogram (drawn by sciencemusic):
Screenshot from 2023-06-29 15-52-34

@sepandhaghighi
Copy link
Member Author

LGTM. Also I trimmed the test.wav down to 60.3KB using sox. Hope everything is right, @sepandhaghighi please check the sound for double-check.

LGTM 🔥

@sadrasabouri sadrasabouri merged commit 00f0c38 into dev Jul 6, 2023
61 checks passed
@sadrasabouri sadrasabouri deleted the test branch July 6, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AHReccese AHReccese AHReccese approved these changes

@sadrasabouri sadrasabouri sadrasabouri approved these changes

Assignees

@sepandhaghighi sepandhaghighi

Labels
test
Projects
None yet
Milestone
nava v0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@sepandhaghighi @sadrasabouri @AHReccese