Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual test checklist #43

Merged
merged 4 commits into from
Apr 20, 2024
Merged

Manual test checklist #43

merged 4 commits into from
Apr 20, 2024

Conversation

sadrasabouri
Copy link
Member

What does this implement/fix? Explain your changes.

Before this we used to add the checklist for local test on different OSs manually to the pull request comments. From now on after this pull request, that checklist will be part of the pull request template.

@sadrasabouri sadrasabouri added the enhancement New feature or request label Apr 18, 2024
@sadrasabouri sadrasabouri self-assigned this Apr 18, 2024
@sadrasabouri sadrasabouri added this to the nava v0.6 milestone Apr 18, 2024
Copy link
Member

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sadrasabouri Please take a look at my comments 🔥

CHANGELOG.md Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Show resolved Hide resolved
@sadrasabouri
Copy link
Member Author

Kindly please re-review @sepandhaghighi

@sepandhaghighi sepandhaghighi added the documentation Improvements or additions to documentation label Apr 20, 2024
Copy link
Member

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sepandhaghighi sepandhaghighi merged commit fc410f9 into dev Apr 20, 2024
73 checks passed
@sepandhaghighi sepandhaghighi deleted the manual-test-checklist branch April 20, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants