NavaThread exception

[sepandhaghighi]

Reference Issues/PRs

What does this implement/fix? Explain your changes.

• NavaThread exception bug fixed

Any other comments?

Local tests on OSs

• macOS
  • Sonoma
• Windows
  • Windows 11
• Linux
  • Ubuntu 20.04

[codecov]

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.48%. Comparing base (07ea3ee) to head (d518a6f).
Report is 1 commits behind head on dev.

Files	Patch %	Lines
nava/thread.py	80.00%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##              dev      #53       +/-   ##
===========================================
+ Coverage   67.88%   96.48%   +28.60%     
===========================================
  Files           4        4               
  Lines         165      170        +5     
  Branches       24       24               
===========================================
+ Hits          112      164       +52     
+ Misses         47        0       -47     
  Partials        6        6               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sepandhaghighi]

@sadrasabouri Currently, it's not straightforward to test this exception, but we will address it in a future PR. Please disregard it for this PR.

[sadrasabouri]

LGTM.
Just a point I wanted to mention here for future reference. Since we are using WINSOUND API, but call alsa directly from the system, they still have difference.
For example in MacOS, for async mode, when running Winsound, it gave the error and process is done, but when calling Alsa, it stuck and needed a Ctrl + C to exit.

You can merge it, I just don't merge it so that you see my message here.

[sepandhaghighi]

LGTM. Just a point I wanted to mention here for future reference. Since we are using WINSOUND API, but call alsa directly from the system, they still have difference. For example in MacOS, for async mode, when running Winsound, it gave the error and process is done, but when calling Alsa, it stuck and needed a Ctrl + C to exit.

You can merge it, I just don't merge it so that you see my message here.

What's the meaning of stuck? It's really weird! This process run on another thread. Can you provide a reproducible example?

[sadrasabouri]

LGTM. Just a point I wanted to mention here for future reference. Since we are using WINSOUND API, but call alsa directly from the system, they still have difference. For example in MacOS, for async mode, when running Winsound, it gave the error and process is done, but when calling Alsa, it stuck and needed a Ctrl + C to exit.
You can merge it, I just don't merge it so that you see my message here.

What's the meaning of stuck? It's really weird! This process run on another thread. Can you provide a reproducible example?

Yes, checkout this on Ubuntu (for example) and see the differnece:

play("path/to/file.wav", engine=Engine.WINSOUND)

and

play("path/to/file.wav", engine=Engine.AFPLAY)

[sadrasabouri]

We decided to fix the raised issue in a separate PR.