Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move docs #47

Merged
merged 5 commits into from
Dec 6, 2023
Merged

Move docs #47

merged 5 commits into from
Dec 6, 2023

Conversation

znicholls
Copy link
Contributor

@znicholls znicholls commented Dec 5, 2023

Pull request

Closes #45

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Example added (either to an existing notebook or as a new notebook, where applicable)
  • Added to changelog/

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9f5e278) 100.00% compared to head (d1b8546) 100.00%.

❗ Current head d1b8546 differs from pull request most recent head 0adac5f. Consider uploading reports for the commit 0adac5f to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #47   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          130       130           
  Branches        19        19           
=========================================
  Hits           130       130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@znicholls znicholls marked this pull request as ready for review December 5, 2023 17:05
@znicholls
Copy link
Contributor Author

Preview docs are here (https://openscm-units--47.org.readthedocs.build/en/47/index.html) can also be checked via the RTD action

Copy link
Member

@mikapfl mikapfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@znicholls znicholls merged commit 5b2835b into main Dec 6, 2023
11 checks passed
@znicholls znicholls deleted the 45-docs branch December 6, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs in private module
3 participants