Add references to request parameters and support dsd=true for source who use core representations for their concepts #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The dataset we are testing against is currently down hence the error, i will rerun checks once it is back up. |
…delist from conceptscheme.
Allow dsd=True to work for core representation
aboddie
changed the title
eblondel
added a commit
that referenced
this pull request
Jan 9, 2025
eblondel
added a commit
that referenced
this pull request
Jan 9, 2025
|
@aboddie I've merged and added additional codes missing. Tests are ongoing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this pull request is to allow IMF_DATA to use dsd=true. These DSDs only directly reference concepts in concept schemes so the references parameter needs to be passed to get the code lists.
Add references to request parameters and it's method.
Modify SDMXREST21Request builder to use references for datastructure resources
Modify readSDMX:
Allow dsd=True to work for core representation by trying to resolve codelist against concept scheme reference.
Update tests to cover IMF_DATA service provider
Update IMF tests to cover how that service provider is envisioned to be used (we have no plans to enable data querying)