Skip to content

Commit

Permalink
Remove breaking abstract isUTC() getter from Rounding.java.
Browse files Browse the repository at this point in the history
Signed-off-by: Finn Carroll <carrofin@amazon.com>
  • Loading branch information
finnegancarroll committed Jan 29, 2025
1 parent de5aa29 commit 640534d
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions server/src/main/java/org/opensearch/common/Rounding.java
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,14 @@ public DateTimeUnit unit() {
return null;
}

/**
* Helper function for checking if the time zone requested for date histogram
* aggregation is utc or not
*/
public boolean isUTC() {
throw new UnsupportedOperationException();

Check warning on line 283 in server/src/main/java/org/opensearch/common/Rounding.java

View check run for this annotation

Codecov / codecov/patch

server/src/main/java/org/opensearch/common/Rounding.java#L283

Added line #L283 was not covered by tests
}

/**
* A strategy for rounding milliseconds since epoch.
*
Expand Down Expand Up @@ -1429,10 +1437,4 @@ public static OptionalLong getInterval(Rounding rounding) {

return OptionalLong.of(interval);
}

/**
* Helper function for checking if the time zone requested for date histogram
* aggregation is utc or not
*/
public abstract boolean isUTC();
}

0 comments on commit 640534d

Please sign in to comment.