-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Star Tree] [Search] Keyword & Numeric Terms Aggregation #17165
base: main
Are you sure you want to change the base?
Conversation
❌ Gradle check result for 7c042b2: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
...er/src/main/java/org/opensearch/search/aggregations/bucket/terms/NumericTermsAggregator.java
Outdated
Show resolved
Hide resolved
❌ Gradle check result for 1420e07: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
...er/src/main/java/org/opensearch/search/aggregations/bucket/terms/NumericTermsAggregator.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Sandesh for the changes. LGTM as changes are mostly similar to date histo aggs.
❌ Gradle check result for 89310be: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17165 +/- ##
============================================
+ Coverage 72.34% 72.36% +0.02%
- Complexity 65731 65819 +88
============================================
Files 5318 5318
Lines 305743 305855 +112
Branches 44350 44375 +25
============================================
+ Hits 221182 221331 +149
- Misses 66394 66464 +70
+ Partials 18167 18060 -107 ☔ View full report in Codecov by Sentry. |
❕ Gradle check result for 89310be: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
@msfroh Rebased against your aggregation restructuring changes and incorporated the new interfaces in this PR as well. :D |
❌ Gradle check result for 06a2ba3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Description
Related Issues
Resolves #16551
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.