Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Star Tree] [Search] Keyword & Numeric Terms Aggregation #17165

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sandeshkr419
Copy link
Contributor

@sandeshkr419 sandeshkr419 commented Jan 28, 2025

Description

  • Adds support for keyword & numeric terms aggregation.
  • Fix for timestamp field to be fetched from request/valueSource instead of hard-coded value

Related Issues

Resolves #16551

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Search:Aggregations labels Jan 28, 2025
@sandeshkr419 sandeshkr419 added backport 2.x Backport to 2.x branch v2.19.0 Issues and PRs related to version 2.19.0 and removed enhancement Enhancement or improvement to existing feature or request Search:Aggregations labels Jan 28, 2025
Copy link
Contributor

❌ Gradle check result for 7c042b2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 1420e07: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

@bharath-techie bharath-techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sandesh for the changes. LGTM as changes are mostly similar to date histo aggs.

Copy link
Contributor

❌ Gradle check result for 89310be: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 89310be: SUCCESS

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 85.47009% with 17 lines in your changes missing coverage. Please review.

Project coverage is 72.36%. Comparing base (1bf8b9c) to head (9b4da43).

Files with missing lines Patch % Lines
...ket/terms/GlobalOrdinalsStringTermsAggregator.java 81.81% 3 Missing and 5 partials ⚠️
...regations/bucket/terms/NumericTermsAggregator.java 90.19% 1 Missing and 4 partials ⚠️
...ensearch/search/startree/StarTreeQueryContext.java 78.57% 1 Missing and 2 partials ⚠️
...rch/aggregations/bucket/terms/TermsAggregator.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17165      +/-   ##
============================================
+ Coverage     72.34%   72.36%   +0.02%     
- Complexity    65731    65819      +88     
============================================
  Files          5318     5318              
  Lines        305743   305855     +112     
  Branches      44350    44375      +25     
============================================
+ Hits         221182   221331     +149     
- Misses        66394    66464      +70     
+ Partials      18167    18060     -107     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

❕ Gradle check result for 89310be: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@sandeshkr419
Copy link
Contributor Author

@msfroh Rebased against your aggregation restructuring changes and incorporated the new interfaces in this PR as well. :D

Copy link
Contributor

❌ Gradle check result for 06a2ba3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Copy link
Contributor

✅ Gradle check result for 9b4da43: SUCCESS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch enhancement Enhancement or improvement to existing feature or request Search:Aggregations v2.19.0 Issues and PRs related to version 2.19.0
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

[Star Tree] [Search] Bucket terms Aggregation with metric aggregation
3 participants