[JPMS Support] Refactoring of org.opensearch.client from :server module
#17272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be simple refactoring compared to previous PR's. Adding @msfroh @andrross @reta to please take a look at this refactoring. |
prudhvigodithi
force-pushed
the
3.0.0-refactor
branch
2 times, most recently
from
24e279d to
ea4ed8f
Compare
prudhvigodithi
changed the title
:server module org.opensearch.client to org.opensearch.core.client:server module org.opensearch.client to org.opensearch.client.server
|
I havent noticed this, coming from https://github.com/opensearch-project/OpenSearch/tree/main/client/rest-high-level/src/main/java/org/opensearch/client/core, we already have |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17272 +/- ##
============================================
+ Coverage 72.31% 72.38% +0.07%
+ Complexity 65549 65493 -56
============================================
Files 5295 5292 -3
Lines 304965 304493 -472
Branches 44291 44218 -73
============================================
- Hits 220536 220416 -120
+ Misses 66376 65988 -388
- Partials 18053 18089 +36 ☔ View full report in Codecov by Sentry. |
reta
reviewed
Feb 6, 2025
...noop-api-plugin/src/main/java/org/opensearch/plugin/noop/action/bulk/RestNoopBulkAction.java
Outdated
Show resolved
Hide resolved
prudhvigodithi
force-pushed
the
3.0.0-refactor
branch
from
ea4ed8f to
ad0fcaa
Compare
prudhvigodithi
changed the title
:server module org.opensearch.client to org.opensearch.client.server:server module org.opensearch.client to org.opensearch.internal.client
prudhvigodithi
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
cwperks,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
nknize and
owaiskazi19
as code owners
prudhvigodithi
requested review from
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
VachaShah,
peternied,
jainankitk and
linuxpi
as code owners
reta
reviewed
Feb 6, 2025
client/rest-high-level/src/main/java/org/opensearch/client/RequestConverters.java
Outdated
Show resolved
Hide resolved
reta
reviewed
Feb 6, 2025
client/rest-high-level/src/test/java/org/opensearch/client/core/tasks/GetTaskResponseTests.java
Outdated
Show resolved
Hide resolved
prudhvigodithi
force-pushed
the
3.0.0-refactor
branch
2 times, most recently
from
4c2bcac to
d74afdd
Compare
prudhvigodithi
changed the title
:server module org.opensearch.client to org.opensearch.internal.clientorg.opensearch.client from :server module
reta
reviewed
Feb 6, 2025
client/rest-high-level/src/main/java/org/opensearch/client/RequestConverters.java
Outdated
Show resolved
Hide resolved
prudhvigodithi
force-pushed
the
3.0.0-refactor
branch
from
d74afdd to
1a228f1
Compare
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
prudhvigodithi
force-pushed
the
3.0.0-refactor
branch
from
1a228f1 to
683cdbc
Compare
reta
approved these changes
Feb 6, 2025
andrross
approved these changes
Feb 6, 2025
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[JPMS Support] Refactor the
:servermoduleorg.opensearch.clienttoorg.opensearch.transport.client.This will remove the split package issue for
org.opensearch.client.Related Issues
Part of #8110
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.