Replace java.security.AccessController with org.opensearch.secure_sm.AccessController in sub projects with SocketAccess class #19803
+248
−514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Contributor
|
❌ Gradle check result for daa1491: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Contributor
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #19803 +/- ##
============================================
- Coverage 73.21% 73.19% -0.02%
- Complexity 71416 71491 +75
============================================
Files 5779 5781 +2
Lines 326332 326534 +202
Branches 47227 47291 +64
============================================
+ Hits 238918 239007 +89
- Misses 68189 68305 +116
+ Partials 19225 19222 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| } while (page != null); | ||
| return deleteResult; | ||
| }); | ||
| } catch (Exception e) { |
Member
There was a problem hiding this comment.
Wondering if this can lead to ClassCastException during runtime?
(applies to other error handling in other places in the PR as well)
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modules in this PR include:
Related Issues
Related to #18339
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.