-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Allow setting index.creation_date on index creation for plugin compatibility and migrations #19931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting index.creation_date on index creation for plugin compatibility and migrations #19931
Conversation
|
@AndreKurait Thanks for the PR, looks like you need to run |
|
@mch2 This seems like a pretty safe change that helps unblock migration scenarios with index state management, any concerns about taking this? |
…ibility and migrations Aligns behavior with snapshot restore to let migrations retain original creation timestamps. Signed-off-by: Andre Kurait <akurait@amazon.com>
d99347a to
07cb2b9
Compare
Updated spotless and added the changelog |
|
❌ Gradle check result for 07cb2b9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
@AndreKurait Looking at the failure - pretty sure it was impacted by this change, look into org.opensearch.client.IndicesClientIT.testCreateIndexFailPrivateSetting |
|
❌ Gradle check result for 07cb2b9: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…al and non-private Signed-off-by: Andre Kurait <akurait@amazon.com>
Signed-off-by: Andre Kurait <akurait@amazon.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19931 +/- ##
============================================
- Coverage 73.21% 73.18% -0.04%
- Complexity 71416 71553 +137
============================================
Files 5779 5785 +6
Lines 326332 326584 +252
Branches 47227 47291 +64
============================================
+ Hits 238918 239001 +83
- Misses 68189 68374 +185
+ Partials 19225 19209 -16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@peternied, I've addressed all tests failures and added new tests to verify behavior. I've updated the behavior to allow updating creation_date during restore of an index with snapshot_restore too |
peternied
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @AndreKurait !
Description
Allow setting index.creation_date on index creation for plugin compatibility and migrations.
Aligns behavior with snapshot restore to let migrations retain original creation timestamps.
Manual Testing
Verified with script which ran with output
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.