Adding remote index and multi-index checks in validation #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
amitgalitz
requested review from
jmazanec15,
jngz-es,
kaituo,
saratvemulapalli,
ohltyler,
vamshin,
VijayanB,
ylwu-amzn,
jackiehanyang,
sean-zheng-amazon,
dbwiddis,
owaiskazi19 and
joshpalis
as code owners
kaituo
reviewed
Sep 3, 2024
Comment on lines
42
to
43
| logger.info("clusterName1: " + clusterName); | ||
| logger.info("clusterService.getClusterName().value(): " + clusterService.getClusterName().value()); |
There was a problem hiding this comment.
Are these logs still needed?
Comment on lines
68
to
69
| String clusterName = parseClusterName(index); | ||
| String indexName = parseIndexName(index); |
There was a problem hiding this comment.
Can you make one call and return a Pair instead of calling similar logic twice?
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1290 +/- ##
============================================
+ Coverage 71.83% 77.46% +5.63%
- Complexity 4898 5445 +547
============================================
Files 518 533 +15
Lines 22879 23319 +440
Branches 2245 2310 +65
============================================
+ Hits 16434 18063 +1629
+ Misses 5410 4199 -1211
- Partials 1035 1057 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
|
kaituo
approved these changes
Sep 3, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
* Adding remote index and multi index checks in validation Signed-off-by: Amit Galitzky <amgalitz@amazon.com> * adding more tests Signed-off-by: Amit Galitzky <amgalitz@amazon.com> --------- Signed-off-by: Amit Galitzky <amgalitz@amazon.com> (cherry picked from commit ec16d53) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jackiehanyang
pushed a commit
that referenced
this pull request
Sep 4, 2024
* Adding remote index and multi index checks in validation * adding more tests --------- (cherry picked from commit ec16d53) Signed-off-by: Amit Galitzky <amgalitz@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
* Adding remote index and multi index checks in validation Signed-off-by: Amit Galitzky <amgalitz@amazon.com> * adding more tests Signed-off-by: Amit Galitzky <amgalitz@amazon.com> --------- Signed-off-by: Amit Galitzky <amgalitz@amazon.com> (cherry picked from commit ec16d53) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amitgalitz
pushed a commit
that referenced
this pull request
Sep 5, 2024
* Adding remote index and multi index checks in validation * adding more tests --------- (cherry picked from commit ec16d53) Signed-off-by: Amit Galitzky <amgalitz@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds ability to validate multiple indices/aliases and remote indices during validation, rest of the remote indexing feature actually works out of the box on any search action that is done.
Tasks left over:
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.