Add disable_authentication flag to the opensearch source #2942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graytaylor0
requested review from
chenqi0805,
engechas,
dinujoh,
kkondaka,
cmanning09,
asifsmohammed,
dlvenable and
oeyh
as code owners
Signed-off-by: Taylor Gray <tylgry@amazon.com>
graytaylor0
force-pushed
the
DisableAuthOS
branch
from
093cf3f
to
28c3465
Compare
engechas
approved these changes
Jun 29, 2023
Comment on lines
+91
to
+93
| if (((Objects.nonNull(awsAuthenticationOptions) && ((Objects.nonNull(username) || Objects.nonNull(password)) || disableAuthentication)) || | ||
| (Objects.nonNull(username) || Objects.nonNull(password)) && disableAuthentication) || | ||
| (Objects.isNull(awsAuthenticationOptions) && (Objects.isNull(username) || Objects.isNull(password)) && !disableAuthentication)) { |
There was a problem hiding this comment.
Minor: it's easier to get a sense of the conditionals by breaking this into a few booleans. Something like
final boolean isAwsAuthValid = ..
final boolean is userNamePasswordValid = ..
if (isAwsAuthValid && !userNamePasswordValid ...)
MaGonzalMayedo
pushed a commit
to MaGonzalMayedo/data-prepper
that referenced
this pull request
Jul 25, 2023
…project#2942) Signed-off-by: Taylor Gray <tylgry@amazon.com> Signed-off-by: Marcos Gonzalez Mayedo <alemayed@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
disable_authenticationflag to the OpenSearch source, which allows auth to be skipped if desired. Defaults to false.Issues Resolved
Resolves #2939
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.