Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements to list_to_map processor #4038

Merged
merged 6 commits into from
Feb 5, 2024

Conversation

oeyh
Copy link
Collaborator

@oeyh oeyh commented Jan 31, 2024

Description

Adds some enhancements to to list_to_map processor:

  • adds use_source_key and extract_value option to dynamically extract values and put them in a list under the source key
  • adds tags_on_failure option to add tags when events failed to process
  • simplifies existing code that uses JsonNode unnecessarily (see this comment on original PR)

Issues Resolved

Resolves #3867

Check List

  • New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Hai Yan <oeyh@amazon.com>
Signed-off-by: Hai Yan <oeyh@amazon.com>
Signed-off-by: Hai Yan <oeyh@amazon.com>
Signed-off-by: Hai Yan <oeyh@amazon.com>
Signed-off-by: Hai Yan <oeyh@amazon.com>
Copy link
Collaborator

@asifsmohammed asifsmohammed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic looks good, please use final keywords when ever possible.

Copy link
Collaborator

@kkondaka kkondaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please document the new config options in README.md.

Also, provide one example in the README.md for each of the options

Signed-off-by: Hai Yan <oeyh@amazon.com>
@oeyh oeyh merged commit 2b8ec72 into opensearch-project:main Feb 5, 2024
44 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combine values under the same key from a list of key-value pairs
3 participants