Fix bug where s3 scan could skip when lastModifiedTimestamps are the same #4124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graytaylor0
requested review from
chenqi0805,
engechas,
dinujoh,
kkondaka,
asifsmohammed,
dlvenable and
oeyh
as code owners
…same Signed-off-by: Taylor Gray <tylgry@amazon.com>
graytaylor0
force-pushed
the
S3ScanFix
branch
from
09cbabf
to
fa158a1
Compare
asifsmohammed
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Thanks for fixing this!
oeyh
approved these changes
Feb 14, 2024
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.6 2.6
# Navigate to the new working tree
cd .worktrees/backport-2.6
# Create a new branch
git switch --create backport/backport-4124-to-2.6
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a8024e99aa4ff0b0d7de86d642fdac14cf1da58d
# Push it to GitHub
git push --set-upstream origin backport/backport-4124-to-2.6
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.6Then, create a pull request where the |
graytaylor0
added a commit
to graytaylor0/data-prepper
that referenced
this pull request
Feb 14, 2024
…same (opensearch-project#4124) Signed-off-by: Taylor Gray <tylgry@amazon.com> (cherry picked from commit a8024e9)
graytaylor0
added a commit
to graytaylor0/data-prepper
that referenced
this pull request
Feb 14, 2024
…same (opensearch-project#4124) Signed-off-by: Taylor Gray <tylgry@amazon.com>
4 tasks
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provides some overlap of a second when filtering out objects based on lastmodified timestamp for subsequent scans. This filtering is done to lower the amount of lookups required to source coordination, and will not result in duplicate processing if there are any objects that are returned to source coordinator twice.
Issues Resolved
Resolves #4123
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.