Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate Processor: local mode should work when there is no when condition #4380

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

kkondaka
Copy link
Collaborator

@kkondaka kkondaka commented Apr 1, 2024

Description

Aggregate Processor: local mode should work when there is no when condition.
local_mode introduced in PR #4306 should do local aggregation when the condition is not specified too.

Issues Resolved

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • [X ] New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • [X ] Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…dition

Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
Copy link
Contributor

@JonahCalvo JonahCalvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kkondaka kkondaka merged commit 2d84ba9 into opensearch-project:main Apr 1, 2024
47 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 1, 2024
…dition (#4380)

Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
Co-authored-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
(cherry picked from commit 2d84ba9)
kkondaka added a commit that referenced this pull request Apr 1, 2024
…dition (#4380) (#4381)

Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
Co-authored-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
(cherry picked from commit 2d84ba9)

Co-authored-by: Krishna Kondaka <41027584+kkondaka@users.noreply.github.com>
@kkondaka kkondaka deleted the local-mode-fix branch May 13, 2024 05:51
@kkondaka kkondaka added this to the v2.8 milestone May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants