Parquet codec tests fix #4698
Merged
Parquet codec tests fix #4698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkondaka
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
asifsmohammed,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
dlvenable
requested changes
Jul 1, 2024
| @@ -115,11 +117,11 @@ void test_happy_case(final int numberOfRecords) throws Exception { | |||
| parquetOutputCodec.writeEvent(event, outputStream); | |||
| } | |||
| parquetOutputCodec.complete(outputStream); | |||
| List<Map<String, Object>> actualRecords = createParquetRecordsList(new ByteArrayInputStream(tempFile.toString().getBytes())); | |||
| List<Map<String, Object>> actualRecords = createParquetRecordsList(new FileInputStream(tempFile)); | |||
There was a problem hiding this comment.
We need assertions on all of these to verify the size. Otherwise, the loop below will not assert anything.
assertThat(actualRecords.size(), equalTo(inputMaps.size()));
| break; | ||
| default: throw new IllegalArgumentException("Unknown field"); | ||
| } | ||
| } catch (RuntimeException e) {continue;} |
There was a problem hiding this comment.
I think we should remove this try-catch. Just let the exception propagate up.
Relatedly, there is an exception below. Can you remove it?
} catch (Exception parquetException) {
LOG.error("Failed to parse Parquet", parquetException);
dlvenable
reviewed
Jul 1, 2024
.github/workflows/static.yml
Outdated
| @@ -0,0 +1,43 @@ | |||
| # Simple workflow for deploying static content to GitHub Pages | |||
There was a problem hiding this comment.
I think this was from a concept you were working. This commit shouldn't be in this branch.
|
Your DCO is failing. |
kkondaka
force-pushed
the
parquet-codec-fix
branch
4 times, most recently
from
1faba56
to
86a100e
Compare
Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
kkondaka
force-pushed
the
parquet-codec-fix
branch
from
86a100e
to
e8aa74c
Compare
Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
graytaylor0
approved these changes
Jul 2, 2024
dlvenable
approved these changes
Jul 2, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
Parquet codec tests fix Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com> (cherry picked from commit a466013)
dlvenable
pushed a commit
that referenced
this pull request
Jul 17, 2024
kkondaka
added a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Jul 23, 2024
Parquet codec tests fix Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
kkondaka
added a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Jul 23, 2024
Parquet codec tests fix Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
kkondaka
added a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Jul 30, 2024
Parquet codec tests fix Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
kkondaka
added a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Aug 8, 2024
Parquet codec tests fix Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
kkondaka
added a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Aug 12, 2024
Parquet codec tests fix Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
kkondaka
added a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Aug 14, 2024
Parquet codec tests fix Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix Parquet output codec tests
Issues Resolved
Resolves #3992
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.