4602 one way hash #4750
Merged
4602 one way hash #4750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mishavay-aws
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
Signed-off-by: mishavay-aws <140549901+mishavay-aws@users.noreply.github.com>
Signed-off-by: mishavay-aws <140549901+mishavay-aws@users.noreply.github.com>
Signed-off-by: mishavay-aws <140549901+mishavay-aws@users.noreply.github.com>
Signed-off-by: mishavay-aws <140549901+mishavay-aws@users.noreply.github.com>
Signed-off-by: mishavay-aws <140549901+mishavay-aws@users.noreply.github.com>
Signed-off-by: mishavay-aws <140549901+mishavay-aws@users.noreply.github.com>
mishavay-aws
force-pushed
the
4602-one-way-hash
branch
from
8b114ca
to
3d2d9d2
Compare
Signed-off-by: mishavay-aws <140549901+mishavay-aws@users.noreply.github.com>
dlvenable
requested changes
Jul 18, 2024
There was a problem hiding this comment.
Thank you @mishavay-aws for this great contribution! I left a few comments and am happy to discuss some of the questions in this review.
.../org/opensearch/dataprepper/plugins/processor/obfuscation/action/OneWayHashActionConfig.java
Outdated
Show resolved
Hide resolved
.../org/opensearch/dataprepper/plugins/processor/obfuscation/action/OneWayHashActionConfig.java
Outdated
Show resolved
Hide resolved
...n/java/org/opensearch/dataprepper/plugins/processor/obfuscation/action/OneWayHashAction.java
Outdated
Show resolved
Hide resolved
...n/java/org/opensearch/dataprepper/plugins/processor/obfuscation/action/OneWayHashAction.java
Outdated
Show resolved
Hide resolved
...n/java/org/opensearch/dataprepper/plugins/processor/obfuscation/action/OneWayHashAction.java
Outdated
Show resolved
Hide resolved
...n/java/org/opensearch/dataprepper/plugins/processor/obfuscation/action/OneWayHashAction.java
Show resolved
Hide resolved
...va/org/opensearch/dataprepper/plugins/processor/obfuscation/action/OneWayHashActionTest.java
Show resolved
Hide resolved
...va/org/opensearch/dataprepper/plugins/processor/obfuscation/action/OneWayHashActionTest.java
Show resolved
Hide resolved
...a/org/opensearch/dataprepper/plugins/processor/obfuscation/action/ObfuscationActionTest.java
Outdated
Show resolved
Hide resolved
| this.salt = config.getSalt(); | ||
| this.saltKey = config.getSaltKey(); | ||
| try{ | ||
| messageDigest = MessageDigest.getInstance(config.getHashFormat()); |
There was a problem hiding this comment.
I'm wondering if we should allow the user to choose any available Java hash algorithm. Should we limit these to a subset?
There was a problem hiding this comment.
My suggestion is only include ones that are asked for/needed. I do not think that we should include weaker ones that are still supported in java for backwards compatibility. I have included SHA-512 as it was asked. Do you have suggestions on other frequently used/ asked-for algorithms?
There was a problem hiding this comment.
I see that you have an @Pattern on the format so that only SHA-512 is allowed. This makes sense.
Signed-off-by: mishavay-aws <140549901+mishavay-aws@users.noreply.github.com>
dlvenable
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Thank you @mishavay-aws for this contribution! It looks good.
kkondaka
pushed a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Aug 8, 2024
added capabilities for working with OneWay Hash Signed-off-by: mishavay-aws <140549901+mishavay-aws@users.noreply.github.com> Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
kkondaka
pushed a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Aug 12, 2024
added capabilities for working with OneWay Hash Signed-off-by: mishavay-aws <140549901+mishavay-aws@users.noreply.github.com> Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
kkondaka
pushed a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Aug 14, 2024
added capabilities for working with OneWay Hash Signed-off-by: mishavay-aws <140549901+mishavay-aws@users.noreply.github.com> Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Added one-way hashing capability using SHA-512 to the obfuscate processor.
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
#4602
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.