Add json property description for list-to-map, map-to-list and user-a… #4759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gent processor Signed-off-by: Hai Yan <oeyh@amazon.com>
oeyh
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
KarstenSchnitter and
dlvenable
as code owners
chenqi0805
approved these changes
Jul 23, 2024
san81
reviewed
Jul 26, 2024
| private String key; | ||
|
|
||
| @JsonProperty("value_key") | ||
| @JsonPropertyDescription("When specified, values given a `value_key` in objects contained in the source list " + |
There was a problem hiding this comment.
Can we use multi line strings now? We already migrated to java 17 right?
There was a problem hiding this comment.
Thought about it, but is it going to help here? The descriptions are often just single sentences (no line breaks in them).
san81
approved these changes
Jul 29, 2024
kkondaka
pushed a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Jul 30, 2024
…gent processor (opensearch-project#4759) Signed-off-by: Hai Yan <oeyh@amazon.com> Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
kkondaka
pushed a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Aug 8, 2024
…gent processor (opensearch-project#4759) Signed-off-by: Hai Yan <oeyh@amazon.com> Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
kkondaka
pushed a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Aug 12, 2024
…gent processor (opensearch-project#4759) Signed-off-by: Hai Yan <oeyh@amazon.com> Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
kkondaka
pushed a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Aug 14, 2024
…gent processor (opensearch-project#4759) Signed-off-by: Hai Yan <oeyh@amazon.com> Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…gent processor
Description
Add json property description for list-to-map, map-to-list and user-agent processor
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.