Fix bug where race condition on ack callback could cause S3 folder partition to not be given up #4835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graytaylor0
requested review from
chenqi0805,
engechas,
dinujoh,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
…rtition to not be given up Signed-off-by: Taylor Gray <tylgry@amazon.com>
graytaylor0
force-pushed
the
S3SourceAckBug
branch
from
3e4704e
to
b575182
Compare
dinujoh
approved these changes
Aug 14, 2024
|
@graytaylor0 I am sure how the race condition is solved just by moving the code. Can you explain? |
kkondaka
pushed a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Aug 20, 2024
…rtition to not be given up (opensearch-project#4835) Signed-off-by: Taylor Gray <tylgry@amazon.com> Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a potential race condition where an S3 source folder partition can receive an acknowledgment callback at the same time as the partition is being updated for the acknowledgment wait, leading to failure to give up the folder partition. This results in objects not being processed from this folder until the acknowledgment timeout is hit, which is currently set to 2 hours
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.