Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: respect json order and class description on processors #4857

Conversation

chenqi0805
Copy link
Collaborator

Description

This PR

  • fills in processor description into @JsonClassDescription for schema generation.
  • adds @JsonPropertyOrder that respects the original property order in POJO.

Issues Resolved

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: George Chen <qchea@amazon.com>
Signed-off-by: George Chen <qchea@amazon.com>
graytaylor0
graytaylor0 previously approved these changes Aug 21, 2024
Signed-off-by: George Chen <qchea@amazon.com>
@chenqi0805 chenqi0805 merged commit b10d465 into opensearch-project:main Aug 21, 2024
40 of 47 checks passed
@chenqi0805 chenqi0805 deleted the enh/json-order-and-class-description-on-processors branch August 21, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants