Updated the readme for opensearch plugin to use date processor in combination with Opensearch sink #4864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshay0709
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
dlvenable
approved these changes
Aug 27, 2024
|
@dlvenable I forgot to sign the DCO in my first commit. Is it required for the PR to be merged? Should I push an additional commit with the DCO? |
|
@akshay0709 , Yes, we do require the DCO per the OpenSearch project policy. You can add the DCO and then force push your commit(s). |
|
@dlvenable I pushed an empty commit with DCO. Let me know if this works. |
|
@akshay0709 , Thank you. The original commit is also missing the sign-off. These steps should resolve it: |
…bination with openaearch indices to ingest into indices based on the timestamp from a field of the incoming record Signed-off-by: Akshay Pawar <akshay070993@gmail.com>
…70993@gmail.com> Signed-off-by: Akshay Pawar <akshay070993@gmail.com>
akshay0709
force-pushed
the
update-doc-date-processor
branch
from
30534e3
to
d8af19d
Compare
|
@dlvenable Done |
chenqi0805
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the readme with example for opensearch plugin to use date processor in combination with openaearch sink to ingest into indices based on the timestamp from a field of the incoming record.
Issues Resolved
#4832
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.