Lambda invoke backoff #5195
Draft
Lambda invoke backoff #5195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com>
Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com>
Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com>
kkondaka
reviewed
Nov 16, 2024
| final Event event = record.getData(); | ||
|
|
||
| // If the condition is false, add the event to resultRecords as-is | ||
| if (whenCondition != null && !expressionEvaluator.evaluateConditional(whenCondition, event)) { |
There was a problem hiding this comment.
When condition is not applicable to sink. I guess you want to send null for sinks.
kkondaka
reviewed
Nov 16, 2024
| Consumer<InvokeResponse> successHandler, | ||
| Consumer<Throwable> failureHandler) { | ||
| final Backoff backoff = Backoff.exponential(INITIAL_DELAY, MAXIMUM_DELAY).withJitter(JITTER_RATE) | ||
| .withMaxAttempts(Integer.MAX_VALUE); |
There was a problem hiding this comment.
maxAttempts should be configurable
kkondaka
reviewed
Nov 16, 2024
| } else if (throwable instanceof RequestTooLargeException) { | ||
| //We should possibly split this out into more chunks | ||
| //Ideally, we shouldn't get into here | ||
| LOG.error("Request too large exception, please check your payload size", throwable); |
There was a problem hiding this comment.
This also should call failureHandler.accept()
kkondaka
reviewed
Nov 16, 2024
| final long delayMillis = backoff.nextDelayMillis(failedAttemptCount.get()); | ||
| if (delayMillis < 0) { | ||
| Thread.currentThread().interrupt(); | ||
| throw new S3RetriesExhaustedException("Lambda retries exhausted. Current Lambda concurrency setting is either too small or too busy."); |
There was a problem hiding this comment.
copy paste issue - S3RetriesExhaustedException. Rename it
kkondaka
reviewed
Nov 16, 2024
|
|
||
| LOG.info("Batch Chunks created after threshold check: {}", batchedBuffers.size()); | ||
| for (Buffer buffer : batchedBuffers) { | ||
| InvokeRequest requestPayload = buffer.getRequestPayload(functionName, invocationType); |
There was a problem hiding this comment.
This code is duplicated between processor and sink
kkondaka
reviewed
Nov 16, 2024
| // Release event handles for records not sent to Lambda | ||
| for (Record<Event> record : records) { | ||
| Event event = record.getData(); | ||
| releaseEventHandle(event, true); |
There was a problem hiding this comment.
Failed records should be sent to DLQ and if it fails there then release should happen with false (negative ack)
Signed-off-by: Srikanth Govindarajan <srigovs@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reusing the code between lambda sink and lambda processor
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.