Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Star Tree Search changes related to new Aggregations supported #9163

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sandeshkr419
Copy link

@sandeshkr419 sandeshkr419 commented Feb 6, 2025

Adding example for star-tree supported date histogram as it is supported in OpenSearch 2.19

Description

Adds details about following features added in 2.19
PRs with feature inclusions:
opensearch-project/OpenSearch#17137
opensearch-project/OpenSearch#16674

Project Meta: opensearch-project/OpenSearch#15257

Issues Resolved

Closes #[delete this text, including the brackets, and replace with the issue number]

Version

OpenSearch 2.19 and above

Frontend features

If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Adding example for star-tree supported date histogram as it is supported in OpenSearch 2.19

Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Copy link

github-actions bot commented Feb 6, 2025

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

Add queries included in 2.19

Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
@kolchfa-aws kolchfa-aws added release-notes PR: Include this PR in the automated release notes v2.19.0 labels Feb 6, 2025
@sandeshkr419 sandeshkr419 changed the title Update star-tree-index.md Star Tree Search changes related to new Aggregations supported Feb 6, 2025
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
@@ -140,14 +140,18 @@ Star-tree indexes can be used to optimize queries and aggregations.

### Supported queries

The following queries are supported as of OpenSearch 2.18:
The following queries are supported as of OpenSearch 2.19:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we capturing the difference in data types supported by indexing v/s search ?
For instance, Unsigned Long is supported in Indexing but not in Search.
Similarly, for IP field as well.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about it, but we did not mention about this in OS 2.18 when only numeric fields were supported in Search. But feel free to suggest how we can capture this information.

- [Match all docs query]({{site.url}}{{site.baseurl}}/query-dsl/match-all/)
- [Range query]({{site.url}}{{site.baseurl}}/query-dsl/term/range/)
Copy link

@expani expani Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't support queryRelation as it mostly used for Date OR NumericRange field types

We look at only 4 values

from
to
includeLower/includeFrom
includeUppoer/includeTo

We can capture the same here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes PR: Include this PR in the automated release notes v2.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants