[Backport 2.x] Removes user_inputs field from Template and Global Context Index mapping #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…ing (#111) * Adding global context index mapping changes Signed-off-by: Joshua Palis <jpalis@amazon.com> * Removes user inputs field from Template class and global context Signed-off-by: Joshua Palis <jpalis@amazon.com> * Adding toJson test for TemplateTests::testStrings() Signed-off-by: Joshua Palis <jpalis@amazon.com> --------- Signed-off-by: Joshua Palis <jpalis@amazon.com> (cherry picked from commit f621b91) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov Report
@@ Coverage Diff @@
## 2.x #112 +/- ##
============================================
- Coverage 81.46% 80.47% -0.99%
+ Complexity 285 252 -33
============================================
Files 30 30
Lines 1122 973 -149
Branches 126 98 -28
============================================
- Hits 914 783 -131
+ Misses 162 155 -7
+ Partials 46 35 -11
|
joshpalis
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport f621b91 from #111.