Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to limit max workflow steps #266

Merged

Conversation

dbwiddis
Copy link
Member

@dbwiddis dbwiddis commented Dec 9, 2023

Description

Adds a setting to limit the max number of steps (nodes) in a workflow.

Issues Resolved

Fixes #260

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dbwiddis dbwiddis changed the base branch from main to feature/agent_framework December 11, 2023 20:50
@dbwiddis dbwiddis changed the base branch from feature/agent_framework to main December 11, 2023 20:55
@dbwiddis dbwiddis changed the base branch from main to feature/agent_framework December 11, 2023 20:58
owaiskazi19 and others added 8 commits December 11, 2023 13:00
Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com>
Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com>
Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com>
…project#226)

* Use only pluginZip publication of Apache Maven artifacts

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Address code review comments

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Address code review comments

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

---------

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
* Initial integ test framework modification, sets up integration test cluster and fixes ./gradlew run

Signed-off-by: Joshua Palis <jpalis@amazon.com>

* spotless

Signed-off-by: Joshua Palis <jpalis@amazon.com>

* Updating DEVELOPER_GUIDE

Signed-off-by: Joshua Palis <jpalis@amazon.com>

---------

Signed-off-by: Joshua Palis <jpalis@amazon.com>
…23.2 (opensearch-project#229)

Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com>
Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Co-authored-by: Owais Kazi <owaiskazi19@gmail.com>
…23.3 (opensearch-project#252)

Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com>
Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com>
….30.0 (opensearch-project#255)

Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com>
Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com>
@dbwiddis dbwiddis force-pushed the max-steps branch 3 times, most recently from 3045f89 to bc5658a Compare December 11, 2023 21:05
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Copy link
Member

@ohltyler ohltyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick addition!

@dbwiddis dbwiddis merged commit 7bec6e8 into opensearch-project:feature/agent_framework Dec 12, 2023
9 of 10 checks passed
@dbwiddis dbwiddis deleted the max-steps branch December 12, 2023 03:05
@opensearch-trigger-bot
Copy link
Contributor

The backport to feature/agent_framework failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/flow-framework/backport-feature/agent_framework feature/agent_framework
# Navigate to the new working tree
pushd ../.worktrees/flow-framework/backport-feature/agent_framework
# Create a new branch
git switch --create backport/backport-266-to-feature/agent_framework
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7bec6e8eb89cc45a1447b209e9cae2bd58dd84e5
# Push it to GitHub
git push --set-upstream origin backport/backport-266-to-feature/agent_framework
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/flow-framework/backport-feature/agent_framework

Then, create a pull request where the base branch is feature/agent_framework and the compare/head branch is backport/backport-266-to-feature/agent_framework.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 12, 2023
* Rename repo name in code files and CI (#182)

Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com>

* Update actions/setup-java action to v4 (#219)

Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com>
Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com>

* Use only pluginZip publication of Apache Maven artifacts (#226)

* Use only pluginZip publication of Apache Maven artifacts

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Address code review comments

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Address code review comments

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

---------

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Integration test infrastructure set up (#230)

* Initial integ test framework modification, sets up integration test cluster and fixes ./gradlew run

Signed-off-by: Joshua Palis <jpalis@amazon.com>

* spotless

Signed-off-by: Joshua Palis <jpalis@amazon.com>

* Updating DEVELOPER_GUIDE

Signed-off-by: Joshua Palis <jpalis@amazon.com>

---------

Signed-off-by: Joshua Palis <jpalis@amazon.com>

* Update dependency com.diffplug.spotless:spotless-plugin-gradle to v6.23.2 (#229)

Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com>
Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com>

* Update to Gradle 8.5 (#227)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Co-authored-by: Owais Kazi <owaiskazi19@gmail.com>

* Update dependency com.diffplug.spotless:spotless-plugin-gradle to v6.23.3 (#252)

Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com>
Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com>

* Update dependency org.eclipse.platform:org.eclipse.core.runtime to v3.30.0 (#255)

Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com>
Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com>

* Add setting to limit max workflow steps

Signed-off-by: Daniel Widdis <widdis@gmail.com>

---------

Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com>
Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Joshua Palis <jpalis@amazon.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Co-authored-by: Owais Kazi <owaiskazi19@gmail.com>
Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com>
Co-authored-by: Andriy Redko <drreta@gmail.com>
Co-authored-by: Joshua Palis <jpalis@amazon.com>
(cherry picked from commit 7bec6e8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@dbwiddis
Copy link
Member Author

Ignoring the backport to this branch... tags were leftover from initial PR to main :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add a max steps check for workflows
5 participants