Update workflow state without using painless script #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #894 +/- ##
============================================
+ Coverage 77.55% 78.04% +0.48%
- Complexity 966 977 +11
============================================
Files 97 97
Lines 4531 4554 +23
Branches 422 423 +1
============================================
+ Hits 3514 3554 +40
+ Misses 835 823 -12
+ Partials 182 177 -5 ☔ View full report in Codecov by Sentry. |
dbwiddis
force-pushed
the
no-painless
branch
2 times, most recently
from
5b6fbc5
to
0907c21
Compare
amitgalitz
reviewed
Oct 2, 2024
src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java
Outdated
Show resolved
Hide resolved
joshpalis
approved these changes
Oct 2, 2024
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
owaiskazi19
reviewed
Oct 3, 2024
src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java
Show resolved
Hide resolved
src/test/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandlerTests.java
Show resolved
Hide resolved
Signed-off-by: Daniel Widdis <widdis@gmail.com>
owaiskazi19
approved these changes
Oct 3, 2024
amitgalitz
approved these changes
Oct 3, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 3, 2024
* Update resources without using painless script Signed-off-by: Daniel Widdis <widdis@gmail.com> * Remove error field without using painless script Signed-off-by: Daniel Widdis <widdis@gmail.com> * Remove unused script update method Signed-off-by: Daniel Widdis <widdis@gmail.com> * Reorder methods for logical relationships Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add change log, more test coverage Signed-off-by: Daniel Widdis <widdis@gmail.com> * Do 5 retries for resource list updates Signed-off-by: Daniel Widdis <widdis@gmail.com> * Make retries a constant Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: Daniel Widdis <widdis@gmail.com> (cherry picked from commit d0879d7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Oct 3, 2024
) Update workflow state without using painless script (#894) * Update resources without using painless script * Remove error field without using painless script * Remove unused script update method * Reorder methods for logical relationships * Add change log, more test coverage * Do 5 retries for resource list updates * Make retries a constant --------- (cherry picked from commit d0879d7) Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes methods using painless script for workflow state updates.
Related Issues
Fixes #779 (except for the part that will be covered by #780)
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.