Fixed testPluginInstalled test #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
owaiskazi19
requested review from
dbwiddis,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov Report
@@ Coverage Diff @@
## main #90 +/- ##
=========================================
Coverage 81.68% 81.68%
Complexity 285 285
=========================================
Files 30 30
Lines 1119 1119
Branches 125 125
=========================================
Hits 914 914
Misses 160 160
Partials 45 45 |
dbwiddis
reviewed
Oct 12, 2023
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
joshpalis
reviewed
Oct 12, 2023
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
owaiskazi19
force-pushed
the
fix-windows-bug
branch
from
c7a7023
to
0ef9df8
Compare
dbwiddis
approved these changes
Oct 13, 2023
amitgalitz
approved these changes
Oct 13, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 13, 2023
* Fixed testPluginInstalled test Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Fixed name Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Removed plugin ordering Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> --------- Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> (cherry picked from commit b1fbe0b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
owaiskazi19
pushed a commit
that referenced
this pull request
Oct 13, 2023
Fixed testPluginInstalled test (#90) * Fixed testPluginInstalled test * Fixed name * Removed plugin ordering --------- (cherry picked from commit b1fbe0b) Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
org.opensearch.flowframework.FlowFrameworkPluginIT.testPluginInstalledtest is failing on Windows CIIssues Resolved
Fixes #87
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.