Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Revert PR #880: Remove temporary fix for integration tests #931

Merged
merged 1 commit into from
Nov 7, 2024
Merged

[Backport 2.x] Revert PR #880: Remove temporary fix for integration tests #931

merged 1 commit into from
Nov 7, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 79bd859 from #930.

@github-actions
Revert PR #880: Remove temporary fix for integration tests (#930)
d2a169a 
Signed-off-by: saimedhi <saimedhi@amazon.com>
(cherry picked from commit 79bd859)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
dbwiddis requested changes Oct 23, 2024
View reviewed changes
Copy link
Member

@dbwiddis dbwiddis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold off on merging until 2.19.0-SNAPSHOT PR is merged to 2.x.

@codecov Codecov
Copy link

codecov bot commented Oct 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.07%. Comparing base (2de661a) to head (d2a169a).
Report is 7 commits behind head on 2.x.

Additional details and impacted files 
@@            Coverage Diff            @@
##                2.x     #931   +/-   ##
=========================================
  Coverage     78.07%   78.07%           
  Complexity      996      996           
=========================================
  Files            99       99           
  Lines          4625     4625           
  Branches        431      431           
=========================================
  Hits           3611     3611           
  Misses          834      834           
  Partials        180      180

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dbwiddis
dbwiddis approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can go ahead and merge this now that 2.18.0 has been releasd.

@dbwiddis dbwiddis merged commit 22eaab0 into 2.x Nov 7, 2024
32 checks passed
@dbwiddis dbwiddis deleted the backport/backport-930-to-2.x branch November 7, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbwiddis dbwiddis dbwiddis approved these changes

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@joshpalis joshpalis Awaiting requested review from joshpalis joshpalis is a code owner

@ohltyler ohltyler Awaiting requested review from ohltyler ohltyler is a code owner

@amitgalitz amitgalitz Awaiting requested review from amitgalitz amitgalitz is a code owner

@jackiehanyang jackiehanyang Awaiting requested review from jackiehanyang jackiehanyang is a code owner

Assignees
No one assigned
Labels
v2.19.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dbwiddis