Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty model_type parameter in anomaly detector suggestion agent template #959

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gaobinlong
Copy link
Contributor

Description

There's an empty model_type parameter existing in the anomaly detector suggestion agent template, which is unused and may introduce confusion, need to remove it.

Related Issues

No issue.

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…t template

Signed-off-by: gaobinlong <gbinlong@amazon.com>
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.57%. Comparing base (35b171e) to head (d8d58d0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #959   +/-   ##
=========================================
  Coverage     77.57%   77.57%           
  Complexity      993      993           
=========================================
  Files            99       99           
  Lines          4714     4714           
  Branches        431      431           
=========================================
  Hits           3657     3657           
  Misses          877      877           
  Partials        180      180           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yuye-aws yuye-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport PRs to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants