Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows CI on 1.3 #1616

Merged

Conversation

naveentatikonda
Copy link
Member

Description

This PR will fix the failing Windows CI on 1.3 by including the following changes:

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
@martin-gaievski
Copy link
Member

Did you have a chance to test this in environment with infra like CI (https://github.com/opensearch-project/opensearch-build/)?

@vibrantvarun
Copy link
Member

+1 to @martin-gaievski

@naveentatikonda
Copy link
Member Author

Did you have a chance to test this in environment with infra like CI (https://github.com/opensearch-project/opensearch-build/)?

Yes, I have a windows RDP machine and tested it there. The build is not failing there because there the gcc version is less than 13. But, in our CI we are using 13.2 so we are running into these issues with headers.

@martin-gaievski
Copy link
Member

Did you have a chance to test this in environment with infra like CI (https://github.com/opensearch-project/opensearch-build/)?

Yes, I have a windows RDP machine and tested it there. The build is not failing there because there the gcc version is less than 13. But, in our CI we are using 13.2 so we are running into these issues with headers.

Discussed offline, patch is installed only for github CI, its got executed as part of checks for this PR

@naveentatikonda naveentatikonda merged commit 07d00d9 into opensearch-project:1.3 Apr 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants