Use 0.95 as default ratio for lucene radial search traversal similarity #1619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
junqiu-lei
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
martin-gaievski and
ryanbogan
as code owners
ryanbogan
reviewed
Apr 17, 2024
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
|
overall code looks good to me. Waiting for CIs to complete. |
jmazanec15
reviewed
Apr 17, 2024
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
jmazanec15
approved these changes
Apr 17, 2024
ryanbogan
approved these changes
Apr 18, 2024
|
Will do manually backport to 2.x with #1617 |
3 tasks
junqiu-lei
added a commit
to junqiu-lei/k-NN
that referenced
this pull request
Apr 26, 2024
…search-project#1652) * Use 0.95 as default ratio for lucene radial search traversal similarity (opensearch-project#1619) Signed-off-by: Junqiu Lei <junqiu@amazon.com>
5 tasks
junqiu-lei
added a commit
that referenced
this pull request
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR set up Lucene engine traversalSimilarity value to 0.95 * resultSimilarity(min_score) based on benchmark result #814 (comment)
Issues Resolved
Part of #814
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.