Fix the put mapping issue for already created index with flat mapper #2542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navneet1v
requested review from
heemin32,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan,
luyuncheng,
shatejas,
0ctopus13prime and
Vikasht34
as code owners
Signed-off-by: Navneet Verma <navneev@amazon.com>
navneet1v
added
Bug Fixes
naveentatikonda
approved these changes
Feb 19, 2025
shatejas
approved these changes
Feb 19, 2025
|
waiting for CIs to complete before merging the PR. |
navneet1v
added a commit
that referenced
this pull request
Feb 19, 2025
jed326
pushed a commit
to jed326/k-NN
that referenced
this pull request
Feb 19, 2025
…pensearch-project#2542) Signed-off-by: Navneet Verma <navneev@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the put mapping issue for already created index with flat mapper
Root Cause:
When put mappings is called for an already created index, the mappings are merged from the old index. During that merge the buildContext https://github.com/opensearch-project/k-NN/blob/main/src/main/java/org/opensearch/knn/index/mapper/KNNVectorFieldMapper.java#L243 doesn't have the index version.
The failure happens only when index.knn is false because checking of the index version is in
&&hence whenindex.knnis true buildContext is not getting hit.Related Issues
Resolves #2540
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.